Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18987: Adding iso type minimal+full-master #2757

Conversation

liatb-rh
Copy link
Contributor

@liatb-rh liatb-rh commented Jan 7, 2025

Adding ISO full/minimal feature to master

@liatb-rh liatb-rh requested a review from a team as a code owner January 7, 2025 14:53
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 7, 2025
Copy link
Collaborator

@jgyselov jgyselov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the infraEnv isn't actually being updated with the image type value. To do that, you will need to replace this line in the stolostron/console repo with

  if (values.imageType) {
    appendPatch(patches, '/spec/imageType', values.imageType, infraEnv.spec?.imageType);
  }

Create a PR there, you can leave it as draft. I'll handle the rest once we release the version.

libs/locales/package.json Outdated Show resolved Hide resolved
libs/sdks/package.json Outdated Show resolved Hide resolved
libs/types/package.json Outdated Show resolved Hide resolved
libs/ui-lib/package.json Outdated Show resolved Hide resolved
libs/ui-lib/lib/cim/components/modals/AddHostModal.tsx Outdated Show resolved Hide resolved
@jgyselov jgyselov changed the title Mgmt-18987-adding iso type minimal+full-master MGMT-18987: Adding iso type minimal+full-master Jan 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2025

@liatb-rh: This pull request references MGMT-18987 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Adding ISO full/minimal feature to master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liatb-rh
Copy link
Contributor Author

liatb-rh commented Jan 9, 2025

Currently, the infraEnv isn't actually being updated with the image type value. To do that, you will need to replace this line in the stolostron/console repo with

  if (values.imageType) {
    appendPatch(patches, '/spec/imageType', values.imageType, infraEnv.spec?.imageType);
  }

Create a PR there, you can leave it as draft. I'll handle the rest once we release the version.

Hi, PR is here, thanks: stolostron/console#4184

jgyselov
jgyselov previously approved these changes Jan 9, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
Copy link

openshift-ci bot commented Jan 9, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liatb-rh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liatb-rh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
@jgyselov
Copy link
Collaborator

Closing in favour of #2764

@jgyselov jgyselov closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants