-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-18987: Adding iso type minimal+full-master #2757
MGMT-18987: Adding iso type minimal+full-master #2757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the infraEnv isn't actually being updated with the image type value. To do that, you will need to replace this line in the stolostron/console repo with
if (values.imageType) {
appendPatch(patches, '/spec/imageType', values.imageType, infraEnv.spec?.imageType);
}
Create a PR there, you can leave it as draft. I'll handle the rest once we release the version.
libs/ui-lib/lib/common/components/clusterConfiguration/DiscoveryImageConfigForm.tsx
Show resolved
Hide resolved
@liatb-rh: This pull request references MGMT-18987 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Co-authored-by: Julie Gyselová <[email protected]>
Co-authored-by: Julie Gyselová <[email protected]>
….com/liatb-rh/assisted-installer-ui into MGMT-18987-Allow-ISO-full-types-2.14
Hi, PR is here, thanks: stolostron/console#4184 |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liatb-rh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liatb-rh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closing in favour of #2764 |
Adding ISO full/minimal feature to master