Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18987: adding iso type minimal+full-2.14 #2740

Open
wants to merge 25 commits into
base: releases/v2.14-cim
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
60aca55
MGMT-19497: It's not needed to add VLAN configuration to bonds interf…
ammont82 Dec 13, 2024
362f1d9
Change order in Operator's page (#2733)
ammont82 Dec 16, 2024
30d74eb
Disable CNV operator when user selects MTV operator (#2717)
ammont82 Dec 17, 2024
c38e369
MGMT-19300: Enable 4/5 CP installation in day1 using assisted-install…
ammont82 Dec 17, 2024
4a5e939
MGMT-19235: Add OpenShift sandboxed containers operator (#2719)
pezhang Dec 17, 2024
d6a58ca
Add MTU validation (#2736)
ammont82 Dec 18, 2024
8427fa5
Remove console.log from code (#2737)
ammont82 Dec 18, 2024
1166f41
Bump nanoid from 3.3.7 to 3.3.8 (#2732)
dependabot[bot] Dec 23, 2024
ec5ca48
Bump @sentry/browser from 6.19.7 to 7.119.1 (#2738)
ammont82 Dec 23, 2024
f25a1cd
adding iso type minimal+full
liatb-rh Dec 30, 2024
9e4ba71
MGMT-19615: Solving problems with history undefined (#2741)
ammont82 Jan 2, 2025
77ca1a4
Add MTV operator to Installation page (#2743)
ammont82 Jan 3, 2025
4b213aa
Clear alerts when starting cluster installation (#2744)
ammont82 Jan 3, 2025
54929e4
If user use bonds+ipv4 withoud bound we need to generate the correct …
ammont82 Jan 3, 2025
27e5881
We don't allow users to continue with cluster creation if not adree w…
ammont82 Jan 3, 2025
09f24ec
Show MTU validation only in networking step (#2745)
ammont82 Jan 3, 2025
52d57b0
Remove not highly available cluster text from Control Plane Nodes dro…
ammont82 Jan 7, 2025
d9bd515
code linting
liatb-rh Jan 7, 2025
1f0628c
Update libs/ui-lib/package.json
liatb-rh Jan 8, 2025
fd24ef8
Update libs/locales/package.json
liatb-rh Jan 8, 2025
88e4aa9
remove version update
liatb-rh Jan 8, 2025
918652f
Merge branch 'MGMT-18987-Allow-ISO-full-types-2.14' of https://github…
liatb-rh Jan 8, 2025
41b146a
keeping buttons group section hide when ipxe
liatb-rh Jan 8, 2025
8c5718a
Merge branch 'master' into MGMT-18987-Allow-ISO-full-types-2.14
liatb-rh Jan 9, 2025
967c4be
Revert "Merge branch 'master' into MGMT-18987-Allow-ISO-full-types-2.14"
liatb-rh Jan 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/locales/lib/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@
"ai:For example: host-{{n}}": "For example: host-{{n}}",
"ai:Format?": "Format?",
"ai:Forwarding it could put your credentials and personal data at risk.": "Forwarding it might put your credentials and personal data at risk.",
"ai:Full image file: Provision with physical media": "Full image file: Provision with physical media",
"ai:Full image file": "Full image file",
"ai:General configuration": "General configuration",
"ai:Generate Discovery ISO": "Generate Discovery ISO",
"ai:Generate script file": "Generate script file",
Expand Down Expand Up @@ -508,7 +508,7 @@
"ai:Message": "Message",
"ai:Metal3 operator is not configured": "Metal3 operator is not configured",
"ai:Migration toolkit for virtualization requirements": "Migration toolkit for virtualization requirements",
"ai:Minimal image file: Provision with virtual media": "Minimal image file: Provision with virtual media",
"ai:Minimal image file": "Minimal image file",
"ai:Minimal value is 10Gi": "Minimal value is 10Gi",
"ai:Minimal value is 1Gi": "Minimal value is 1Gi",
"ai:Minimum CPU cores": "Minimum CPU cores",
Expand Down
2 changes: 1 addition & 1 deletion libs/locales/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@
"lint": "yarn run -T eslint --cache --cache-location node_modules/.cache/eslint/.eslint-cache ."
},
"type": "module",
"version": "2.14.0-cim"
"version": "1.0.0"
liatb-rh marked this conversation as resolved.
Show resolved Hide resolved
}
2 changes: 1 addition & 1 deletion libs/sdks/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openshift-assisted/sdks",
"version": "2.14.0-cim",
"version": "1.0.0",
liatb-rh marked this conversation as resolved.
Show resolved Hide resolved
"exports": {
"./package.json": "./package.json",
"./assisted-installer-service": {
Expand Down
2 changes: 1 addition & 1 deletion libs/types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@
"js-yaml": "^4.1.0",
"sw2dts": "^2.6.3"
},
"version": "2.14.0-cim"
"version": "1.0.0"
liatb-rh marked this conversation as resolved.
Show resolved Hide resolved
}
9 changes: 4 additions & 5 deletions libs/ui-lib/lib/cim/components/modals/AddHostModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@ const AddHostModal: React.FC<AddHostModalProps> = ({
const hasDHCP = infraEnv.metadata?.labels?.networkType !== 'static';
const sshPublicKey = infraEnv.spec?.sshAuthorizedKey || agentClusterInstall?.spec?.sshPublicKey;
const { httpProxy, httpsProxy, noProxy } = infraEnv.spec?.proxy || {};

const isoDialog = agentClusterInstall ? 'config' : 'download';
const [dialogType, setDialogType] = React.useState<AddHostModalStepType>(isoDialog);
const imageType = infraEnv.spec?.imageType || 'minimal-iso';
const [dialogType, setDialogType] = React.useState<AddHostModalStepType>('config');
const { t } = useTranslation();
const handleIsoConfigSubmit = async (
values: DiscoveryImageFormValues,
Expand Down Expand Up @@ -66,8 +65,8 @@ const AddHostModal: React.FC<AddHostModalProps> = ({
<DiscoveryImageConfigForm
onCancel={onClose}
handleSubmit={handleIsoConfigSubmit}
hideDiscoveryImageType={true} // So far configured by env variable on backend
imageType="full-iso" // So far the only option for CIM
hideDiscoveryImageType={isIPXE}
imageType={imageType}
sshPublicKey={sshPublicKey}
httpProxy={httpProxy}
httpsProxy={httpsProxy}
Expand Down
1 change: 1 addition & 0 deletions libs/ui-lib/lib/cim/types/k8s/infra-env-k8s-resource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export type InfraEnvK8sResource = K8sResourceCommon & {
additionalNTPSources?: string[];
cpuArchitecture?: 'x86_64' | 'arm64' | 's390x';
osImageVersion?: string;
imageType?: 'full-iso' | 'minimal-iso';
};
status?: {
agentLabelSelector?: Selector;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,26 +116,24 @@ export const DiscoveryImageConfigForm: React.FC<DiscoveryImageConfigFormProps> =
<>
<ModalBoxBody>
<Stack hasGutter>
<StackItem>
<Alert
variant={AlertVariant.info}
isInline
title={
isIPXE
? t('ai:To add hosts to the cluster, generate iPXE script.')
: t('ai:To add hosts to the cluster, generate a Discovery ISO.')
}
/>
</StackItem>
{hasDHCP === false && (
<StackItem>
<StaticIPInfo docVersion={docVersion} />
</StackItem>
)}
<StackItem>
<Form>
<AlertFormikError status={status as StatusErrorType} />
{!hideDiscoveryImageType && <DiscoveryImageTypeControlGroup />}
<AlertFormikError status={status as StatusErrorType} />
<Alert
variant={AlertVariant.info}
isInline
title={
isIPXE
? t('ai:To add hosts to the cluster, generate iPXE script.')
: t('ai:To add hosts to the cluster, generate a Discovery ISO.')
}
/>
<UploadSSH />
<ProxyFields />
</Form>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Stack, StackItem } from '@patternfly/react-core';
import { Flex, FlexItem } from '@patternfly/react-core';
import { PopoverIcon, RadioField } from '../ui';
import { useTranslation } from '../../hooks/use-translation-wrapper';

Expand All @@ -20,38 +20,38 @@ const DiscoveryImageTypeControlGroupLabel = ({
const DiscoveryImageTypeControlGroup = () => {
const { t } = useTranslation();
return (
<Stack hasGutter>
<StackItem>
<Flex>
<FlexItem spacer={{ default: 'spacer3xl' }}>
<RadioField
name={GROUP_NAME}
id={'minimal-iso'}
value={'minimal-iso'}
label={
<DiscoveryImageTypeControlGroupLabel
text={t('ai:Minimal image file: Provision with virtual media')}
text={t('ai:Minimal image file')}
popoverContent={t(
"ai:Recommended option. The generated discovery ISO will be smaller, but will need to download additional data during boot. This option is useful if ISO storage capacity is limited or if it's being served over a constrained network.",
)}
/>
}
/>
</StackItem>
<StackItem>
</FlexItem>
<FlexItem>
<RadioField
name={GROUP_NAME}
id={'full-iso'}
value={'full-iso'}
label={
<DiscoveryImageTypeControlGroupLabel
text={t('ai:Full image file: Provision with physical media')}
text={t('ai:Full image file')}
popoverContent={t(
'ai:The generated discovery ISO will contain everything needed to boot.',
)}
/>
}
/>
</StackItem>
</Stack>
</FlexItem>
</Flex>
);
};

Expand Down
2 changes: 1 addition & 1 deletion libs/ui-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -139,5 +139,5 @@
]
}
},
"version": "2.14.0-cim"
"version": "1.0.0"
liatb-rh marked this conversation as resolved.
Show resolved Hide resolved
}
Loading