-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed test client initialization in fetching to ensure tests run locally #879
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nikita Furin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
- Coverage 71.95% 70.39% -1.56%
==========================================
Files 91 125 +34
Lines 8001 9290 +1289
==========================================
+ Hits 5757 6540 +783
- Misses 2244 2750 +506 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nikita Furin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two failing test suites with this change, care to take a look?
Signed-off-by: Nikita Furin <[email protected]>
Hmmm, this seems like a workaround around a workaround. I see a lot of code like this Feels like a fix should be somewhere deeper. What are the state(s) of your environment variables |
To reproduce the issue, just follow the DEVELOPER_GUIDE. So, in the local environment, OPENSEARCH_PASSWORD may be set. OPENSEARCH_INITIAL_ADMIN_PASSWORD is for integration tests. I’m currently unable to dedicate time to explore a deeper solution. At the moment, the code isn’t working as intended. If the extra two lines in the tests feel unnecessary to you, you’re welcome to refactor it, but unfortunately, I won’t be able to take that on right now. |
Thanks for your help so far @nokados. |
Description
It fixes the same problem as in #267 in the same way, but this time it was caused by
fetch_opensearch_repo
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.