configure.ac: generate prte_version.h properly #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have prte_version.h generated via AC_CONFIG_HEADERS, not AC_CONFIG_FILES. This properly quotes strings (which technically doesn't matter here since prte_version.h doesn't include any strings) and also won't overwrite the resulting .h file if it hasn't changed. Signed-off-by: Jeff Squyres <[email protected]>
|
Sure - correctness is a good thing! Thx! |
|
this sort of change broke running autogen.pl for me on my rhel8 system |
|
Oddly enough, so do I on my Rocky9 system - but not on my Mac 🤷♂️ . Will revert it until we can figure it out. |
Really? WTF? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have prte_version.h generated via AC_CONFIG_HEADERS, not AC_CONFIG_FILES. This properly quotes strings (which technically doesn't matter here since prte_version.h doesn't include any strings) and also won't overwrite the resulting .h file if it hasn't changed.
This is a minor fix, but I saw it so I thought I'd PR it if you care. 😄