Fix conversion of OMPI MCA params from legacy ORTE #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pickup and convert all "OMPI_MCA_orte_xxx" params to their PRRTE equivalent. Note that some don't have a PRRTE equivalent, so those will silently be ignored as it would be too big a job to try and detect and warn for them. Signed-off-by: Ralph Castain <[email protected]>
Delay processing of PRRTE params until after the selected schizo component gets a chance to translate params (e.g., from OMPI to PRRTE). Ensure we detect the "--display alloc" request and honor it for the DVM itself. Signed-off-by: Ralph Castain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert OMPI MCA params from legacy orte
Pickup and convert all "OMPI_MCA_orte_xxx" params
to their PRRTE equivalent. Note that some don't
have a PRRTE equivalent, so those will silently
be ignored as it would be too big a job to try
and detect and warn for them.
Signed-off-by: Ralph Castain [email protected]
Fix display of DVM allocation
Delay processing of PRRTE params until after the
selected schizo component gets a chance to translate
params (e.g., from OMPI to PRRTE). Ensure we detect
the "--display alloc" request and honor it for the
DVM itself.
Signed-off-by: Ralph Castain [email protected]