Skip to content

Commit

Permalink
Correctly return after sending
Browse files Browse the repository at this point in the history
Once we send the bootstrap to the HNP, we need to return - don't
allow a second message to be sent

Signed-off-by: Ralph Castain <[email protected]>
  • Loading branch information
rhc54 committed Nov 22, 2024
1 parent 0bfee1d commit 98835f3
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/mca/grpcomm/direct/grpcomm_direct_group.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ int prte_grpcomm_direct_group(pmix_group_operation_t op, char *grpid,
prte_pmix_grp_caddy_t *cd;

PMIX_OUTPUT_VERBOSE((1, prte_grpcomm_base_framework.framework_output,
"%s grpcomm:direct:group with %lu procs",
PRTE_NAME_PRINT(PRTE_PROC_MY_NAME), nprocs));
"%s grpcomm:direct:group for %s with %lu procs",
PRTE_NAME_PRINT(PRTE_PROC_MY_NAME), grpid, nprocs));

cd = PMIX_NEW(prte_pmix_grp_caddy_t);
cd->op = op;
Expand Down Expand Up @@ -244,8 +244,8 @@ static void group(int sd, short args, void *cbdata)
/* if this is a bootstrap operation, send it directly to the HNP */
if (0 < sig.bootstrap || NULL == sig.members) {
PMIX_OUTPUT_VERBOSE((1, prte_grpcomm_base_framework.framework_output,
"%s grpcomm:direct:grp bootstrap sending to HNP",
PRTE_NAME_PRINT(PRTE_PROC_MY_NAME)));
"%s grpcomm:direct:grp bootstrap sending %lu bytes to HNP",
PRTE_NAME_PRINT(PRTE_PROC_MY_NAME), relay->bytes_used));

PRTE_RML_SEND(rc, PRTE_PROC_MY_HNP->rank, relay,
PRTE_RML_TAG_GROUP);
Expand All @@ -255,6 +255,8 @@ static void group(int sd, short args, void *cbdata)
PMIX_DESTRUCT(&sig);
goto error;
}
PMIX_DESTRUCT(&sig);
return;
}
PMIX_DESTRUCT(&sig);

Expand Down

0 comments on commit 98835f3

Please sign in to comment.