Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return meat per subject when computing empirical covariance matrix of coefficients #495

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

zhangh12
Copy link
Contributor

@zhangh12 zhangh12 commented Jan 5, 2025

This can resolve issue #494. Unit tests are added.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, thanks @zhangh12 !
In addition can you please:

  • see if this makes sense to be added in the documentation of the functions
  • check if this makes sense to be mentioned in the vignette describing the robust cov estimators
  • add a corresponding component() access
  • add a NEWS entry

src/empirical.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you @zhangh12 , please see last comments inside, afterwards it should be all done

DESCRIPTION Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/component.R Outdated Show resolved Hide resolved
@danielinteractive danielinteractive enabled auto-merge (squash) January 13, 2025 04:09
@danielinteractive danielinteractive merged commit 6412516 into openpharma:main Jan 13, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants