Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ramp in place of non existing class *_link #32 #33

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

frodrigo
Copy link
Contributor

The style use *_link class of transportation, but there is no such class in OMT. The link have the attribute ramp to 1.

This PR fix the link layers, and add ramp != 1 to non link layers.

While fixing this, it appear some link layers are missing on tunnels: add it.

Note: this PR is conflict with my other PR #25 (just on code indentation), but please accept or reject PR. So can build PR more easily.

Changes on motorway junction
imagen
imagen

Trunk - primary junction
imagen
imagen

Trunk -primary - tertiary junction with tunnels and bridges #17.14/45.752288/4.820813
imagen
imagen

@TomPohys
Copy link
Member

TomPohys commented Sep 1, 2020

Thanks @frodrigo for adjusting the ramp. Could you please resolve the conflict and check the #34 and #35 if are ready to be merged?

Thanks a lot

@frodrigo
Copy link
Contributor Author

frodrigo commented Sep 1, 2020

Done, Rebased (and all other PR).

@TomPohys
Copy link
Member

TomPohys commented Sep 2, 2020

Thanks, @frodrigo.

@TomPohys TomPohys merged commit c10e242 into openmaptiles:master Sep 2, 2020
@frodrigo frodrigo deleted the ramp_and_link branch December 17, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants