Implement setRegistryId for CancelRequestItem. Bump patch version

openlibraryenvironment · Apr 30, 2024 · b1a487c · b1a487c
1 parent deaa244
commit b1a487c
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/lib-ncip-cli/pom.xml b/lib-ncip-cli/pom.xml
@@ -2,7 +2,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>org.olf.rs</groupId>
     <artifactId>lib-ncip-cli</artifactId>
-    <version>0.23.7</version>
+    <version>0.23.8</version>
     <name>lib-ncip-cli</name>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

diff --git a/lib-ncip-client/pom.xml b/lib-ncip-client/pom.xml
@@ -2,7 +2,7 @@
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>org.olf.rs</groupId>
 	<artifactId>lib-ncip-client</artifactId>
-	<version>0.23.7</version>
+	<version>0.23.8</version>
 	<name>NCIP Client</name>
 	<properties>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

diff --git a/lib-ncip-client/src/main/java/org/olf/rs/circ/client/CancelRequestItem.java b/lib-ncip-client/src/main/java/org/olf/rs/circ/client/CancelRequestItem.java
@@ -40,6 +40,11 @@ public CancelRequestItem setRequestId(String requestId) {
         return this;
     }
 
+    public CancelRequestItem setRegistryId(String registryId) {
+        this.registryId = registryId;
+        return this;
+    }
+
     @Override
     public NCIPInitiationData generateNCIP2Object() {
         CancelRequestItemInitiationData cancelRequestItemInitiationData = new CancelRequestItemInitiationData();

diff --git a/...t/src/test/java/org/olf/rs/circ/client/unitTests/transactions/CancelRequestItemTests.java b/...t/src/test/java/org/olf/rs/circ/client/unitTests/transactions/CancelRequestItemTests.java
@@ -33,15 +33,15 @@ public void testGenerateNcip1Response() {
 
     @Test
     public void testConstructNcip2Response() throws Exception {
-        CancelRequestItem requestItem = new CancelRequestItem();
+        CancelRequestItem cancelRequestItem = new CancelRequestItem();
         CancelRequestItemResponseData cancelRequestItemResponseData = new CancelRequestItemResponseData();
         ItemId itemId = new ItemId();
         itemId.setItemIdentifierValue("22334455");
         RequestId requestId = new RequestId();
         requestId.setRequestIdentifierValue("RESH-99");
         cancelRequestItemResponseData.setItemId(itemId);
         cancelRequestItemResponseData.setRequestId(requestId);
-        JSONObject jsonObject = requestItem.constructResponseNcip2Response(cancelRequestItemResponseData);
+        JSONObject jsonObject = cancelRequestItem.constructResponseNcip2Response(cancelRequestItemResponseData);
         assertEquals(jsonObject.getString("itemId"), "22334455");
         assertEquals(jsonObject.getString("requestId"), "RESH-99");
     }
@@ -52,6 +52,7 @@ public void testToString() {
         cancelRequestItem.setRequestId("123");
         cancelRequestItem.setFromAgency("ABC");
         cancelRequestItem.setToAgency("CBA");
+        cancelRequestItem.setRegistryId("44556677");
         String asString = cancelRequestItem.toString();
         assertTrue(asString.contains("123"));
         assertTrue(asString.contains("CBA"));

diff --git a/pom.xml b/pom.xml
@@ -2,7 +2,7 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <groupId>org.olf.rs</groupId>
-    <version>0.23.7</version>
+    <version>0.23.8</version>
     <artifactId>lib-ncip-client-proj</artifactId>
     <packaging>pom</packaging>
     <name>lib-ncip-client-proj</name>