feat: custom spans #2287
Merged
feat: custom spans #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia1
reviewed
Nov 26, 2024
KishenKumarrrrr
temporarily deployed
to
staging
GitHub Actions
Inactive
KishenKumarrrrr
temporarily deployed
to
staging
GitHub Actions
Inactive
KishenKumarrrrr
temporarily deployed
to
staging
GitHub Actions
Inactive
KishenKumarrrrr
temporarily deployed
to
staging
GitHub Actions
Inactive
KishenKumarrrrr
temporarily deployed
to
staging
GitHub Actions
Inactive
KishenKumarrrrr
had a problem deploying
to
staging
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is a continuation of #2285. After previously removing the logging of the entire record objects, the ELB 502s during callback spikes continued to occur. While trying to debug the issue further, we realised that the existing traces in DD did not contain sufficient information.
In this PR, I manually add custom spans to the callback endpoint that we are interested in so that we can hopefully better understand where the bottlenecks in this endpoint lie.
💡 The newly created spans are still a little wonky. My guess is that this is due to the implementation of this endpoint where there are many overlapping asynchronous operations being executed at the same time.
Before
After (No DB calls in the SS because this is on staging, we will have them on production)