Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Convert Privacy warning to bottom sheet #6213

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Afroz-Shaikh
Copy link

What

Turned the Open Prices privacy warning into a bottom sheet for improved user experience and better alignment with the UI design standards.
Replaced the current modal/dialog with a Flutter showModalBottomSheet.
Screenshot

image

Fixes bug(s)

Fixes: #6183

@Afroz-Shaikh Afroz-Shaikh changed the title Feat: Convert Privacy warning to bottom sheet feat: Convert Privacy warning to bottom sheet Jan 15, 2025
@teolemon
Copy link
Member

We're using the following layout @Afroz-Shaikh #5755
cc @g123k

@g123k
Copy link
Collaborator

g123k commented Jan 15, 2025

You have the method showSmoothModalSheet + the SmoothModalSheet for the content.
Also, don't forget a SafeArea, otherwise your button with be under the status bar

@Afroz-Shaikh
Copy link
Author

Will implement the same using showSmoothModalSheet and SmoothModalSheet
thanks a lot @g123k & @teolemon

@Afroz-Shaikh
Copy link
Author

Afroz-Shaikh commented Jan 15, 2025

Does this align with the project's guidelines, @teolemon? I've used showSmoothModalSheet along with SmoothActionButtonBar with +ve action —let me know if this implementation is appropriate

I’ll update the code once confirmed.
cc: @g123k
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Turn the Open Prices privacy warning into a bottom sheet
3 participants