Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI improvements for the edit mode #6132

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 6, 2025

Hi everyone!

I've improved a little bit the UI for the edit mode with:

  • A bolder title
  • Elements are aligned 😇

Untitled

Also for the website field, it was a bit empty:
Untitled1

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 129 lines in your changes missing coverage. Please review.

Project coverage is 6.36%. Comparing base (4d9c7fc) to head (0ca1d44).
Report is 614 commits behind head on develop.

Files with missing lines Patch % Lines
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% 48 Missing ⚠️
...mooth_app/lib/generic_lib/widgets/smooth_card.dart 0.00% 46 Missing ⚠️
...mooth_app/lib/pages/product/simple_input_page.dart 0.00% 15 Missing ⚠️
..._app/lib/pages/product/add_other_details_page.dart 0.00% 14 Missing ⚠️
...ib/pages/input/smooth_autocomplete_text_field.dart 0.00% 3 Missing ⚠️
...app/lib/pages/product/simple_input_text_field.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6132      +/-   ##
==========================================
- Coverage     9.54%   6.36%   -3.18%     
==========================================
  Files          325     448     +123     
  Lines        16411   25574    +9163     
==========================================
+ Hits          1567    1629      +62     
- Misses       14844   23945    +9101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added 🌐 l10n ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users autocomplete labels Jan 6, 2025
@g123k
Copy link
Collaborator Author

g123k commented Jan 6, 2025

Small change: instead of the expanding explanation, when we have a "Container", there is now a Help icon.
It will allow us to improve this content later (by adding some images, animations…)

🎥 Video: https://github.com/user-attachments/assets/ce9ba12b-05b7-48db-8e35-30f28ef4c68a

IMG_901EE117D38B-1
IMG_B064A233D8CB-1

@g123k g123k linked an issue Jan 6, 2025 that may be closed by this pull request
@teolemon teolemon merged commit d1ebb68 into openfoodfacts:develop Jan 6, 2025
6 checks passed
@teolemon
Copy link
Member

teolemon commented Jan 6, 2025

Swell one @g123k

@g123k g123k deleted the edit_mode_ui branch January 6, 2025 19:23
@github-throwaway
Copy link

Damn. You guys work fast ⚡️🔥

You only changed English and French, right? What about the other languages?

@g123k
Copy link
Collaborator Author

g123k commented Jan 6, 2025

Damn. You guys work fast ⚡️🔥

You only changed English and French, right? What about the other languages?

For the other languages, it's via Crowdin.
https://wiki.openfoodfacts.org/Translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🌐 l10n 🥫 Product page
Development

Successfully merging this pull request may close these issues.

Update ingredients tooltip to remove obsolete instructions
4 participants