Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use the search eye animation from the POC #4833

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 22, 2023

Hi everyone,

To infuse some touches of the POC, here is an opportunity to import the animation mechanism.
To reduce time and memory consumption, the Rive file is loaded as a singleton on top of the hierarchy.

Instead of the wide empty loading screen, I've (temporary) replaced it with:
Screenshot 2023-11-22 at 09 33 34

Link to the animation: https://rive.app/s/lwcPXxyZq0ahW2uldNpfKQ/

TODO (in a later PR): Migrate existing Rive animations with this mechanism

Part of

@codecov-commenter
Copy link

Codecov Report

Attention: 122 lines in your changes are missing coverage. Please review.

Comparison is base (40f4c0e) 9.85% compared to head (7945e2b) 9.78%.

Files Patch % Lines
...kages/smooth_app/lib/resources/app_animations.dart 0.00% 99 Missing ⚠️
...p/lib/pages/product/common/product_query_page.dart 0.00% 15 Missing ⚠️
packages/smooth_app/lib/main.dart 0.00% 6 Missing ⚠️
packages/smooth_app/lib/widgets/smooth_text.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4833      +/-   ##
==========================================
- Coverage     9.85%   9.78%   -0.08%     
==========================================
  Files          312     313       +1     
  Lines        15839   15954     +115     
==========================================
  Hits          1561    1561              
- Misses       14278   14393     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 09d32c1 into openfoodfacts:develop Nov 24, 2023
7 checks passed
@g123k g123k deleted the search_animation branch November 25, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants