Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: On lists, ensure to always add new items to the top #4211

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 18, 2023

Hi everyone,

Still as part of #3986, on lists (labels, categories…), we currently append new items to the bottom.
When we have 10+ items, it's pretty difficult to know if the item is added or not.

To simplify things, the UI will now show the new items on top of the list, but internally, they still be added to the end.

As always, a video is better than words: custom_sort.webm

@g123k g123k added the ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users label Jun 18, 2023
@g123k g123k requested a review from a team as a code owner June 18, 2023 17:48
@g123k g123k self-assigned this Jun 18, 2023
@g123k g123k changed the title On lists, ensure to always add new items to the top feat: On lists, ensure to always add new items to the top Jun 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Merging #4211 (ea15250) into develop (6ce7f75) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4211      +/-   ##
===========================================
- Coverage    11.23%   11.23%   -0.01%     
===========================================
  Files          277      277              
  Lines        13694    13698       +4     
===========================================
  Hits          1539     1539              
- Misses       12155    12159       +4     
Impacted Files Coverage Δ
...ges/smooth_app/lib/helpers/collections_helper.dart 12.50% <0.00%> (-0.55%) ⬇️
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@g123k g123k force-pushed the lists_insert_first branch from 92f258f to ea15250 Compare June 18, 2023 18:02
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch 👍

@teolemon teolemon merged commit 992c81c into openfoodfacts:develop Jun 20, 2023
@g123k g123k deleted the lists_insert_first branch June 20, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants