feat: Fully working lifecycle for the Robotoff question in the Product page #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🌐 l10n
Product addition
Codecov Report
@@ Coverage Diff @@
## develop #4198 +/- ##
===========================================
- Coverage 10.88% 10.87% -0.02%
===========================================
Files 277 277
Lines 13600 13652 +52
===========================================
+ Hits 1481 1484 +3
- Misses 12119 12168 +49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
As noted in #4199, this PR is critical as it fixes the performance issue of an infinite redraw |
M123-dev
approved these changes
Jun 18, 2023
Comment on lines
+142
to
+144
| // TODO(jasmeet): Use Material icon or SVG (after consulting UX). | ||
| Text( | ||
| '🏅 ${appLocalizations.tap_to_answer}', |
There was a problem hiding this comment.
Guess we can apply that some time, jasmeet0817 no longer is working on the app
When there is no question, -> the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
Currently, when we scroll up/down on the Product page, the Robotoff Widget is reloaded every time.
My PR fixes this with a
KeepAlive, but as an improvement over #3326, during the loading time, a Shimmer is shown to prevent the List from being offset when the content is ready.Better than words, a video: robotoff_lifecycle.webm
EDIT: I've also changed a little bit the animation of the question page (I know it's meaningless from the product page, but may be used elsewhere) Zoom.webm