feat: Improve the animation and the accessibility of the ExplanationWidget
#4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g123k
added
♿️ accessibility
✏️ Editing
Codecov Report
@@ Coverage Diff @@
## develop #4196 +/- ##
===========================================
- Coverage 10.88% 10.88% -0.01%
===========================================
Files 277 277
Lines 13600 13607 +7
===========================================
Hits 1481 1481
- Misses 12119 12126 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
Still as part of #3986, I have improved the animation when we expand/collapse the explanation Widget.
ExplanationWidget.webm
For accessibility, this Widget is not clickable, as it will say the full explanation directly:
