feat: Added nutrition input to product addition flow #1626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimaelQuemerais
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1626 +/- ##
==========================================
- Coverage 8.86% 8.68% -0.18%
==========================================
Files 161 164 +3
Lines 6623 6813 +190
==========================================
+ Hits 587 592 +5
- Misses 6036 6221 +185
Continue to review full report at Codecov.
|
teolemon
added
the
Product addition
|
should work again |
1 task
M123-dev
approved these changes
Apr 26, 2022
| import 'package:openfoodfacts/model/ProductImage.dart'; | ||
| import 'package:smooth_app/generic_lib/buttons/smooth_action_button.dart'; | ||
| import 'package:smooth_app/generic_lib/buttons/smooth_large_button_with_icon.dart'; | ||
| import 'package:smooth_app/generic_lib/design_constants.dart'; | ||
| import 'package:smooth_app/pages/image_crop_page.dart'; | ||
| import 'package:smooth_app/pages/product/confirm_and_upload_picture.dart'; | ||
|
|
||
| import 'nutrition_page_loaded.dart'; | ||
| import 'ordered_nutrients_cache.dart'; |
There was a problem hiding this comment.
Please use package import's here
Comment on lines
+252
to
+254
| if (cache == null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Is this a somewhat likely case, if so a Snackbar or a todo comment would be good
|
@PrimaelQuemerais can you do the 2 little adjustments proposed by @M123-dev , and Let'sJustMerge™ |
|
Closing and reopening with the fixes since I rebased my fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Part of