Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit methods for folksonomy #967

Merged

Conversation

monsieurtanuki
Copy link
Contributor

What

  • We had no way to edit (add/update/delete) Folksonomy data, because we needed authentication.
  • The authentication method is now available, and so are the "edit" methods.

Part of

Impacted files

  • api_folksonomy_test.dart: tests on the new folksonomy methods
  • folksonomy.dart: new methods getAuthenticationToken, addProductTag, deleteProductTag, updateProductTag; minor refactoring
  • http_helper.dart: new method doPutRequest
  • price_per.dart: unrelated minor refactoring

Impacted files:
* `api_folksonomy_test.dart`: tests on the new folksonomy methods
* `folksonomy.dart`: new methods `getAuthenticationToken`, `addProductTag`, `deleteProductTag`, `updateProductTag`; minor refactoring
* `http_helper.dart`: new method `doPutRequest`
* `price_per.dart`: unrelated minor refactoring
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @monsieurtanuki 🙏
I had a little too much fun with that Wiko Jerry: https://world.new.openproductsfacts.org/product/6943279410511/wiko-jerry-noir-space-grey ;-)

@monsieurtanuki monsieurtanuki merged commit 3775abb into openfoodfacts:master Sep 5, 2024
4 of 5 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants