Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test Oxf servers #861

Closed

Conversation

monsieurtanuki
Copy link
Contributor

What

  • The purpose of this PR is to get rid of annoying emails about some specific tests non passing.
  • In that particular case, the OxF servers are sometimes funny in their heads, and getProduct (and of course the corresponding URL) fails with a 504 Gateway Time-out.
  • Instead of receiving error messages about problems that do not regard our code but the current status of the OxF servers, we ignore the tests when we have 504 exceptions.

Impacted files

  • api_not_food_get_product_test.dart: added tests around 504 Gateway Time-out
  • open_food_api_client.dart: minor refactoring
  • pubspec.yaml: minor package upgrades

Impacted files:
* `api_not_food_get_product_test.dart`: added tests around `504 Gateway Time-out`
* `open_food_api_client.dart`: minor refactoring
* `pubspec.yaml`: minor package upgrades
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2c6ba80) 75.80% compared to head (78bd96d) 75.79%.

Files Patch % Lines
test/api_not_food_get_product_test.dart 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   75.80%   75.79%   -0.02%     
==========================================
  Files         224      224              
  Lines        7903     7902       -1     
==========================================
- Hits         5991     5989       -2     
- Misses       1912     1913       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 📸 Open Products Facts 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org labels Jan 25, 2024
@monsieurtanuki
Copy link
Contributor Author

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts
Projects
Development

Successfully merging this pull request may close these issues.

3 participants