Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xblock-submit-and-compare | Replace pkg_resources to importlib_resources | Drop support for python 3.8 #187

Merged
merged 9 commits into from
Sep 27, 2024
Merged

xblock-submit-and-compare | Replace pkg_resources to importlib_resources | Drop support for python 3.8 #187

merged 9 commits into from
Sep 27, 2024

Conversation

ttqureshi
Copy link

@ttqureshi ttqureshi commented Sep 13, 2024 •
edited
Loading

Overview

This PR:

  • replaces pkg_resources api from importlib_resources api
  • drops support for python 3.8 and add support for python 3.11 & python 3.12

Tickets:

Followed this migration guide.

Testing

I have tested the changes against the following steps:

  • Install and setup xblock-submit-and-compare in studio
  • Tested the functionality of xblock-submit-and-compare in studio
  • Run tox tests

Screenshots

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 13, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ttqureshi!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@farhan
Copy link

farhan commented Sep 16, 2024

Please update major version as we have dropped support of Python 3.8

https://github.com/openedx/xblock-submit-and-compare/pull/187/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R10

@ttqureshi
Copy link
Author

okay

farhan
farhan reviewed Sep 16, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
submit_and_compare/mixins/scenario.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@farhan
Copy link

farhan commented Sep 23, 2024

Please update major version as we have dropped support of Python 3.8

https://github.com/openedx/xblock-submit-and-compare/pull/187/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R10

Please address this

farhan
farhan suggested changes Sep 23, 2024
View reviewed changes
submit_and_compare/mixins/scenario.py Outdated Show resolved Hide resolved
farhan
farhan reviewed Sep 23, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ttqureshi ttqureshi force-pushed the ttqureshi/depr_pkg_resources branch from b6178b8 to 5613e06 Compare September 23, 2024 12:42
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 23, 2024
@ttqureshi ttqureshi force-pushed the ttqureshi/depr_pkg_resources branch from 5613e06 to c772066 Compare September 24, 2024 14:32
@ttqureshi
chore: Drop support for python 3.8
886700a 
- Drop support for python 3.8 and add support for python 3.11 and 3.12
@ttqureshi ttqureshi force-pushed the ttqureshi/depr_pkg_resources branch from c772066 to 8405d88 Compare September 24, 2024 14:40
ttqureshi and others added 8 commits September 24, 2024 19:41
@ttqureshi ttqureshi force-pushed the ttqureshi/depr_pkg_resources branch from 8405d88 to 31d4e36 Compare September 24, 2024 14:41
@mphilbrick211 mphilbrick211 added needs reviewer assigned PR needs to be (re-)assigned a new reviewer and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Sep 27, 2024
@feanil feanil merged commit f5ed1f0 into openedx:master Sep 27, 2024
10 checks passed
@itsjeyd itsjeyd removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan farhan farhan approved these changes

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python 3.8 & Add Support for Python 3.12 Move on from deprecated pkg_resources api
6 participants
@ttqureshi @openedx-webhooks @farhan @feanil @itsjeyd @mphilbrick211