Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add outlined videoCam icon #2750

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

KristinAoki
Copy link
Member

@KristinAoki KristinAoki commented Oct 26, 2023

Description

Add VideoCamOutline icon.

Deploy Preview

https://deploy-preview-2750--paragon-openedx.netlify.app/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 172aa64
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/653abb449734be00082c6541
😎 Deploy Preview https://deploy-preview-2750--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Worth a check on the deploy preview for the PR once it's done building to make sure it shows up as expected on the docs site before it merges :)

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2747ac1) 92.82% compared to head (172aa64) 92.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2750   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         235      235           
  Lines        4237     4237           
  Branches     1029     1029           
=======================================
  Hits         3933     3933           
  Misses        300      300           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit 47e4379 into master Oct 26, 2023
8 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/add-outline-video-cam-icon branch October 26, 2023 19:36
@openedx-semantic-release-bot

🎉 This PR is included in version 21.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants