feanil/fix readme #145
Merged
feanil/fix readme #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build showed this warning: Warning: You are using "pypa/gh-action-pypi-publish@master". The "master" branch of this project has been sunset and will not receive any updates, not even security bug fixes. Please, make sure to use a supported version. If you want to pin to v1 major version, use "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous, you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1" instead. A more general recommendation is to pin to exact tags or commit shas.
feanil
force-pushed
the
feanil/fix_readme
branch
2 times, most recently
from
738697c to
dec75e5
Compare
feanil
force-pushed
the
feanil/fix_readme
branch
from
dec75e5 to
939d4e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 11 11
Lines 461 461
Branches 33 33
=======================================
Hits 460 460
Partials 1 1 ☔ View full report in Codecov by Sentry. |
brian-smith-tcril
approved these changes
Apr 11, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish a long_description so releases work again.
It looks like this wasn't required before but now the publish fails without it.
This PR also had to update codecov to the latest version and behind the scenes a github actions secret was added with the CODECOV_TOKEN so that codecov uploads will work here.