-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include paragon in atlas pull as well #622
Conversation
This is a follow up to openedx#612 This pull request is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 7 7
======================================
Misses 7 7 ☔ View full report in Codecov by Sentry. |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@OmarIthawi It might helpful to edit the instructions to indicate the minimum version of frontend-platform consumers need for using intl-imports.js, perhaps with a link to its release notes. |
Good catch @adamstankiewicz , I've already gone through all MFEs and updated them. This line should be removed from my pull request templates. As you probably guess, this template is copied to provide as much information as possible for anyone reviewing the PRs related to OEP-58. |
@OmarIthawi Got it! Just a heads up, I don't have access to the link you shared 😀 thanks for the clarification. |
Sorry, I've made it public now. |
This is a follow up to #612 . #612 should have included the changes but apparently OEP-58 needs more publicity.
Testing
I've ran the following:
Generates the following code, which seems to be good:
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes:
For Micro-frontends:
src/i18n/index.js
atlas
integration inmake pull_translations
but only ifOPENEDX_ATLAS_PULL
is setintl-imports.js
to generate up to date import files