Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure prepush lint returns error on failure #897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brian-smith-tcril
Copy link

@brian-smith-tcril brian-smith-tcril commented Aug 1, 2023

After making openedx/frontend-app-admin-portal#1014, I did a full search of the org for ; npm run and ended up here. I updated prepush in package.json to use && instead of ; to ensure we return an error code on lint failure.

@brian-smith-tcril
Copy link
Author

brian-smith-tcril commented Aug 1, 2023

Even with this change in place I was able to push a commit containing lint errors to my fork. It's possible this is intended, but if not I figured it's worth noting.

I also don't know what went into the decision to use prepush here, it seems frontend-app-admin-portal uses precommit

@brian-smith-tcril brian-smith-tcril changed the title fix: ensure lint returns error on failure fix: ensure prepush lint returns error on failure Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (983a602) 67.04% compared to head (37b5374) 67.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #897   +/-   ##
=======================================
  Coverage   67.04%   67.04%           
=======================================
  Files         128      128           
  Lines        3207     3207           
  Branches      935      935           
=======================================
  Hits         2150     2150           
  Misses       1008     1008           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant