-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: iframe rendering optimization #1544
base: master
Are you sure you want to change the base?
chore: iframe rendering optimization #1544
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by @openedx/2u-tnl. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
2b254df
to
59f96a9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
+ Coverage 93.23% 93.29% +0.05%
==========================================
Files 1098 1098
Lines 21709 21706 -3
Branches 4593 4686 +93
==========================================
+ Hits 20240 20250 +10
+ Misses 1404 1385 -19
- Partials 65 71 +6 ☔ View full report in Codecov by Sentry. |
9c320e4
to
f290f99
Compare
refactor: corrected scroll to target xblock refactor: fixed scroll behavior to xblock element refactor: after rebase refactor: fixed tests refactor: updated tests
f290f99
to
4168e54
Compare
Sandbox deployment successful 🚀 |
🚨 Dependencies:
Description
This PR provides iframe reload optimizations for various xblock related actions. Added some improvements related to scrolling to the current xblock. Fixed behavior of the xblock action dropdown list.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Other information
Include anything else that will help reviewers and consumers understand the change.
Settings