-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paragon form component deprecations #612
Conversation
…nd used alternatives
…l and used alternatives
…e component for SelectField
Codecov ReportBase: 39.43% // Head: 38.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
- Coverage 39.43% 38.56% -0.87%
==========================================
Files 109 110 +1
Lines 2229 2279 +50
Branches 597 622 +25
==========================================
Hits 879 879
- Misses 1265 1315 +50
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small-ish factoring change... I also want to pull the branch down and test it. Were you able to visually verify all these changes worked? I know some of these UIs are hard to find.
…ullah/paragon-form-deprecations
Yes I have tested these changes. Let me share screenshots of changes with PR |
…ullah/paragon-form-deprecations
…ullah/paragon-form-deprecations
…ullah/paragon-form-deprecations
…ullah/paragon-form-deprecations
* refactor: removed deprecated paragon components from CoachingToggle and used alternatives * refactor: removed deprecated paragon components from ConfirmationModal and used alternatives * refactor: removed deprecations from EditableField and created separate component for SelectField * refactor: updated DemographicsSection to use new select component * refactor: removed deprecations from EmailField and used alternatives * refactor: removed deprecated Input from CoachingConsentForm * refactor: removed deprecated Input from DemographicsSection * refactor: removed deprecated Input from SummaryPanel component * refactor: removed deprecated CheckBox and used Form.CheckBox * refactor: fixed unit tests * refactor: changes based on PR reviews * fix: linting issue
* refactor: removed deprecated paragon components from CoachingToggle and used alternatives * refactor: removed deprecated paragon components from ConfirmationModal and used alternatives * refactor: removed deprecations from EditableField and created separate component for SelectField * refactor: updated DemographicsSection to use new select component * refactor: removed deprecations from EmailField and used alternatives * refactor: removed deprecated Input from CoachingConsentForm * refactor: removed deprecated Input from DemographicsSection * refactor: removed deprecated Input from SummaryPanel component * refactor: removed deprecated CheckBox and used Form.CheckBox * refactor: fixed unit tests * refactor: changes based on PR reviews * fix: linting issue
* chore: update dependencies to alpha version * fix: migrated functions to arrow functions to fix linting * Paragon form component deprecations (openedx#612) * refactor: removed deprecated paragon components from CoachingToggle and used alternatives * refactor: removed deprecated paragon components from ConfirmationModal and used alternatives * refactor: removed deprecations from EditableField and created separate component for SelectField * refactor: updated DemographicsSection to use new select component * refactor: removed deprecations from EmailField and used alternatives * refactor: removed deprecated Input from CoachingConsentForm * refactor: removed deprecated Input from DemographicsSection * refactor: removed deprecated Input from SummaryPanel component * refactor: removed deprecated CheckBox and used Form.CheckBox * refactor: fixed unit tests * refactor: changes based on PR reviews * fix: linting issue * refactor: migrate off modal paragon depreciation components (openedx#654) * refactor: worked on modal paragon depreciation component and changed them into latest paragon modals * refactor: migrate off modal paragon depreciation components * fix: fix eslint and commit message * fix: units tests were not working, its fixed * test: add unit tests in modal * test: add unit tests in id verfication modal * refactor: convert test cases from enzyme to react testing library * refactor: remove empty file * fix: downgrade paragon to 21.0.0
Ticket
Migrate off deprecated Paragon components
What has changed
Updated deprecated
ValidationFormGroup
toForm.Group
,Input
toForm.Control
andCheckbox
toForm. CheckBox
and updated respective unit testsCreated a separate
EditableSelectField
for selections asEditableField
would become much conditional.