Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragon form component deprecations #612

Merged
merged 17 commits into from
Nov 8, 2022

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Updated deprecated ValidationFormGroup to Form.Group, Input to Form.Control and Checkbox to Form. CheckBox and updated respective unit tests
Created a separate EditableSelectField for selections as EditableField would become much conditional.

@abdullahwaheed abdullahwaheed requested a review from a team July 19, 2022 09:31
@abdullahwaheed abdullahwaheed self-assigned this Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Base: 39.43% // Head: 38.56% // Decreases project coverage by -0.86% ⚠️

Coverage data is based on head (342c163) compared to base (3a2075d).
Patch coverage: 64.06% of modified lines in pull request are covered.

❗ Current head 342c163 differs from pull request most recent head 3b445c0. Consider uploading reports for the commit 3b445c0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   39.43%   38.56%   -0.87%     
==========================================
  Files         109      110       +1     
  Lines        2229     2279      +50     
  Branches      597      622      +25     
==========================================
  Hits          879      879              
- Misses       1265     1315      +50     
  Partials       85       85              
Impacted Files Coverage Δ
src/account-settings/AccountSettingsPage.jsx 0.00% <0.00%> (ø)
src/account-settings/EditableField.jsx 0.00% <0.00%> (-73.92%) ⬇️
src/account-settings/EmailField.jsx 0.00% <0.00%> (ø)
.../account-settings/coaching/CoachingConsentForm.jsx 100.00% <ø> (ø)
src/account-settings/coaching/CoachingToggle.jsx 0.00% <0.00%> (ø)
src/account-settings/demographics/Checkboxes.jsx 9.09% <0.00%> (-4.55%) ⬇️
src/id-verification/panels/SummaryPanel.jsx 96.00% <ø> (ø)
src/account-settings/EditableSelectField.jsx 77.08% <77.08%> (ø)
...ount-settings/delete-account/ConfirmationModal.jsx 81.81% <100.00%> (+1.17%) ⬆️
...ount-settings/demographics/DemographicsSection.jsx 87.75% <100.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidjoy davidjoy requested review from davidjoy and removed request for a team August 11, 2022 12:08
Copy link
Contributor

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small-ish factoring change... I also want to pull the branch down and test it. Were you able to visually verify all these changes worked? I know some of these UIs are hard to find.

src/account-settings/EditableSelectField.jsx Outdated Show resolved Hide resolved
@abdullahwaheed
Copy link
Contributor Author

One small-ish factoring change... I also want to pull the branch down and test it. Were you able to visually verify all these changes worked? I know some of these UIs are hard to find.

Yes I have tested these changes. Let me share screenshots of changes with PR

@abdullahwaheed abdullahwaheed merged commit 547d55a into master Nov 8, 2022
@abdullahwaheed abdullahwaheed deleted the abdullah/paragon-form-deprecations branch November 8, 2022 13:42
moonesque pushed a commit to edSPIRIT/frontend-app-account that referenced this pull request Nov 11, 2023
* refactor: removed deprecated paragon components from CoachingToggle and used alternatives

* refactor: removed deprecated paragon components from ConfirmationModal and used alternatives

* refactor: removed deprecations from EditableField and created separate component for SelectField

* refactor: updated DemographicsSection to use new select component

* refactor: removed deprecations from EmailField and used alternatives

* refactor: removed deprecated Input from CoachingConsentForm

* refactor: removed deprecated Input from DemographicsSection

* refactor: removed deprecated Input from SummaryPanel component

* refactor: removed deprecated CheckBox and used Form.CheckBox

* refactor: fixed unit tests

* refactor: changes based on PR reviews

* fix: linting issue
dcoa pushed a commit to eduNEXT/frontend-app-account that referenced this pull request Dec 4, 2023
* refactor: removed deprecated paragon components from CoachingToggle and used alternatives

* refactor: removed deprecated paragon components from ConfirmationModal and used alternatives

* refactor: removed deprecations from EditableField and created separate component for SelectField

* refactor: updated DemographicsSection to use new select component

* refactor: removed deprecations from EmailField and used alternatives

* refactor: removed deprecated Input from CoachingConsentForm

* refactor: removed deprecated Input from DemographicsSection

* refactor: removed deprecated Input from SummaryPanel component

* refactor: removed deprecated CheckBox and used Form.CheckBox

* refactor: fixed unit tests

* refactor: changes based on PR reviews

* fix: linting issue
dcoa added a commit to eduNEXT/frontend-app-account that referenced this pull request Dec 15, 2023
* chore: update dependencies to alpha version

* fix: migrated functions to arrow functions to fix linting

* Paragon form component deprecations (openedx#612)

* refactor: removed deprecated paragon components from CoachingToggle and used alternatives

* refactor: removed deprecated paragon components from ConfirmationModal and used alternatives

* refactor: removed deprecations from EditableField and created separate component for SelectField

* refactor: updated DemographicsSection to use new select component

* refactor: removed deprecations from EmailField and used alternatives

* refactor: removed deprecated Input from CoachingConsentForm

* refactor: removed deprecated Input from DemographicsSection

* refactor: removed deprecated Input from SummaryPanel component

* refactor: removed deprecated CheckBox and used Form.CheckBox

* refactor: fixed unit tests

* refactor: changes based on PR reviews

* fix: linting issue

* refactor:  migrate off  modal paragon depreciation components (openedx#654)

* refactor:  worked on modal paragon depreciation component and changed them into latest paragon modals

* refactor:  migrate off  modal paragon depreciation components

* fix: fix eslint and commit message

* fix: units tests were not working, its fixed

* test: add unit tests in modal

* test: add unit tests in id verfication modal

* refactor: convert test cases from enzyme to react testing library

* refactor: remove empty file

* fix: downgrade paragon to 21.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants