Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply amnesty on existing not fixable issues #32215

Merged
merged 37 commits into from
Aug 7, 2023

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented May 10, 2023

Ticket

Feasibility of applying amnesty on the existing eslint warnings.

Description

This PR applies amnesty on all eslint issues that are not auto-fixable.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft May 10, 2023 08:11
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/eslint-amnesty branch from 5537007 to f0da55c Compare May 11, 2023 10:25
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this May 15, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi changed the title Ali abbas/eslint amnesty chore: apply amnesty on existing not fixable issues May 18, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review May 18, 2023 10:20
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the file level warning suppressions.

@abdullahwaheed abdullahwaheed merged commit 8480dbc into master Aug 7, 2023
@abdullahwaheed abdullahwaheed deleted the Ali-Abbas/eslint-amnesty branch August 7, 2023 14:13
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants