feat: Remove unusued background_task transaction. #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakhuang
force-pushed
the
diana/refactor-monitoring
branch
2 times, most recently
from
8b8e83d to
f9f6a7b
Compare
robrap
reviewed
Oct 16, 2024
dianakhuang
force-pushed
the
diana/refactor-monitoring
branch
from
f9f6a7b to
cd70e28
Compare
robrap
reviewed
Oct 16, 2024
dianakhuang
force-pushed
the
diana/refactor-monitoring
branch
2 times, most recently
from
4834ac6 to
0d064f8
Compare
robrap
reviewed
Oct 16, 2024
dianakhuang
force-pushed
the
diana/refactor-monitoring
branch
3 times, most recently
from
34815e3 to
c8d5a19
Compare
background_task is seemingly unusued, so it has been removed. Also add comments explaining get_current_transaction is internal-only and will not be exposed via API. Remove most public references to it. Also refactor code so that it is only used in the file where it's used.
dianakhuang
force-pushed
the
diana/refactor-monitoring
branch
from
c8d5a19 to
169acb7
Compare
robrap
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add comments explaining get_current_transaction is internal-only and will not be exposed via API.
#419
Merge checklist:
Post merge:
finished.