Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

refactor: migrated deprecated Input and ValidationForm group components #617

Merged
merged 17 commits into from
Jan 24, 2023
Merged

refactor: migrated deprecated Input and ValidationForm group components #617

merged 17 commits into from
Jan 24, 2023

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Updated deprecated ValidationFormGroup to Form.Group and Input to Form.Control.

@abdullahwaheed abdullahwaheed requested a review from a team as a code owner August 3, 2022 11:30
@mphilbrick211
Copy link

Hi @abdullahwaheed! I'm just following up on this PR - do you intend to keep this open and run the required tests?

@abdullahwaheed
Copy link
Contributor Author

Hi @mphilbrick211. Yes this PR is for paragon form deprecations and is intended to keep. Please run tests on it

@mphilbrick211
Copy link

@colinbrash could you please allow tests to run?

@arbrandes arbrandes mentioned this pull request Nov 16, 2022
Open
26 tasks
@pshiu
Copy link
Contributor

pshiu commented Nov 17, 2022

Closing to see if tests will re-run if re-opened.

@pshiu pshiu closed this Nov 17, 2022
@pshiu pshiu reopened this Nov 17, 2022
@pshiu
Copy link
Contributor

pshiu commented Nov 17, 2022

@abdullahwaheed Could take a look at the snapshot tests failure? (See CI failure.) I think snapshots might just need to be updated but am not sure.

@abdullahwaheed
Copy link
Contributor Author

@pshiu let me check

@abdullahwaheed
Merge branch 'master' of github.com:edx/frontend-app-payment into abd…
6811f32 
…ullahwaheed/paragon-form-deprecations
@abdullahwaheed
Merge branch 'abdullahwaheed/paragon-form-deprecations' of github.com…
54239eb 
…:abdullahwaheed/frontend-app-payment into abdullahwaheed/paragon-form-deprecations
@abdullahwaheed
refactor: updated unit tests
d51d67f
@abdullahwaheed
Copy link
Contributor Author

@pshiu audit step is failing again 😞

@arbrandes
Copy link

@abdullahwaheed, maybe a rebase will help?

@mphilbrick211
Copy link

Hi @abdullahwaheed! Friendly ping on Adolfo's suggestion to rebase.

@arbrandes
Copy link

Looks like tests have passed, but now we need a merge with master. Care to do that, @abdullahwaheed?

Otherwise, any objections, @pshiu?

pshiu
pshiu approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@pshiu pshiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @abdullahwaheed & @arbrandes!

@abdullahwaheed
Copy link
Contributor Author

@arbrandes we can't merge in this repo. @pshiu could you please merge it?

@arbrandes arbrandes mentioned this pull request Jan 24, 2023
Closed
44 tasks
@arbrandes arbrandes changed the title Paragon form component deprecations refactor: migrated deprecated Input and ValidationForm group components Jan 24, 2023
@arbrandes arbrandes merged commit f6fe875 into openedx-unsupported:master Jan 24, 2023
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/paragon-form-deprecations branch January 27, 2023 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pshiu pshiu pshiu approved these changes

@colinbrash colinbrash Awaiting requested review from colinbrash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abdullahwaheed @mphilbrick211 @pshiu @arbrandes @jmbowman