Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix: Minor bugs in default config due to missing feature flags #1842

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

HamzaIsrar12
Copy link
Contributor

Description

LEARNER-9732

Resolve the following issues in this PR:

  • Fix the API version problem on the register screen
  • Manage the "My Courses" screen title when programs are absent
  • Address the functionality of the "View all dates" button on sync dates when the dates tab is absent
  • Remove unused code from the config

- Fix the API version problem on the register screen
- Manage the "My Courses" screen title when programs are absent
- Address the functionality of the "View all dates" button on sync
 dates when the dates tab is absent
- Remove unused code from the config

Fixes: LEARNER-9732
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (0749897) 1.07% compared to head (ee4f6ff) 1.07%.

Files Patch % Lines
...src/main/java/org/edx/mobile/view/LearnFragment.kt 0.00% 14 Missing ⚠️
...bile/src/main/java/org/edx/mobile/util/Config.java 0.00% 4 Missing ⚠️
...org/edx/mobile/view/CourseTabsDashboardFragment.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1842   +/-   ##
========================================
  Coverage      1.07%   1.07%           
  Complexity      137     137           
========================================
  Files           538     538           
  Lines         26314   26312    -2     
  Branches       3391    3390    -1     
========================================
  Hits            284     284           
+ Misses        26003   26001    -2     
  Partials         27      27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor nit else LGTM 👍

@HamzaIsrar12 HamzaIsrar12 merged commit 9564a17 into master Dec 21, 2023
4 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-9732 branch December 21, 2023 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants