Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Refactored iap code #4150

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Refactored iap code #4150

merged 1 commit into from
Apr 2, 2024

Conversation

jawad-khan
Copy link
Contributor

⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH

  • I have checked the branch to which I would like to merge.

⛔️ DEPRECATION WARNING

This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.

Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]

Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Required Testing

  • Before deploying this change, complete a purchase in the stage environment.
    (^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)

Description

Refactored iap code, improved test coverage and removed deprictaed params.

Supporting information

Here is the JIRA TICKET for refactoring.

Testing instructions

Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, OpenEdx vs. edx.org differences, development vs. production environment differences, security, or accessibility.

@jawad-khan jawad-khan requested a review from a team as a code owner April 1, 2024 08:52
@jawad-khan jawad-khan requested a review from moeez96 April 1, 2024 08:53
@zubair-ce07 zubair-ce07 self-assigned this Apr 2, 2024
@jawad-khan jawad-khan merged commit 4e33cbe into 2u/main Apr 2, 2024
10 checks passed
@jawad-khan jawad-khan deleted the LEARNER-9892 branch April 2, 2024 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants