Stop emit default value for counter TotalError and ReaderRestartProcessing

src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/PerformanceAnalyzerApp.java

@@ -121,8 +121,6 @@ public static void main(String[] args) {
               (MetricsConfiguration.CONFIG_MAP.get(StatsCollector.class).samplingInterval) / 2,
               TimeUnit.MILLISECONDS);
       METRIC_COLLECTOR_EXECUTOR.addScheduledMetricCollector(StatsCollector.instance());
-      StatsCollector.instance()
-          .addDefaultExceptionCode(StatExceptionCode.READER_RESTART_PROCESSING);
       METRIC_COLLECTOR_EXECUTOR.setEnabled(true);
       METRIC_COLLECTOR_EXECUTOR.start();
 

src/main/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/collectors/StatsCollector.java

@@ -26,6 +26,7 @@
 import java.io.InputStream;
 import java.text.SimpleDateFormat;
 import java.util.Date;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -52,6 +53,12 @@ public class StatsCollector extends PerformanceAnalyzerMetricsCollector {
   private Map<String, AtomicInteger> counters = new ConcurrentHashMap<>();
   private Date objectCreationTime = new Date();
 
+  private static final Map<String, String> DEFAULT_STATS_DATA = new HashMap<>();
+
+  static {
+    DEFAULT_STATS_DATA.put("MethodName", "CollectStatsMetric");
+  }
+
   private List<StatExceptionCode> defaultExceptionCodes = new Vector<>();
 
   public static StatsCollector instance() {
@@ -124,7 +131,6 @@ public StatsCollector(String name, int samplingIntervalMillis, Map<String, Strin
     super(samplingIntervalMillis, name);
     this.metadata = metadata;
     addRcaVersionMetadata(this.metadata);
-    defaultExceptionCodes.add(StatExceptionCode.TOTAL_ERROR);
   }
 
   private StatsCollector(Map<String, String> metadata) {
@@ -150,7 +156,7 @@ public void collectMetrics(long startTime) {
     }
 
     writeStats(
-        metadata, currentCounters, null, null, objectCreationTime.getTime(), new Date().getTime());
+        metadata, currentCounters, DEFAULT_STATS_DATA, null, objectCreationTime.getTime(), new Date().getTime());
     collectAndWriteRcaStats();
     objectCreationTime = new Date();
   }

src/test/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/PerformanceAnalyzerAppTest.java

@@ -26,5 +26,7 @@ public void testMain() {
     PerformanceAnalyzerApp.main(new String[0]);
     Assert.assertFalse(ConfigStatus.INSTANCE.haveValidConfig());
     Assert.assertEquals(StatsCollector.instance().getCounters().get("ReaderThreadStopped").get(), 1);
+    Assert.assertEquals(StatsCollector.instance().getCounters().get("TotalError").get(), 1);
+    Assert.assertFalse(StatsCollector.instance().getCounters().containsKey("ReaderRestartProcessing"));
   }
-}
+}