This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Changing metricsDB provider while executing an integTest #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the gauntlet only let's you provide the metricsDB table at the top of a test class or at the top of a test method. But sometimes during the test test execution, one might want to change the instance of metricsDB. This is made possible by this patch. In order to do that, You create a new inner class (doesn't have to be inner) with an appropriate name. Add, the metrics details as you would if you were to do it as part of the main test class itself. @aMetric(name = CPU_Utilization.class, dimensionNames = {SHARDID_VALUE, INDEX_NAME_VALUE, OPERATION_VALUE, SHARD_ROLE_VALUE}, tables = { @aTable(hostTag = HostTag.DATA_0, tuple = { @atuple(dimensionValues = {"0", "logs", "bulk", "p"}, sum = 0.0, avg = 0.0, min = 0.0, max = 111.0), @atuple(dimensionValues = {"1", "logs", "bulk", "r"}, sum = 0.0, avg = 0.0, min = 0.0, max = 88.0), @atuple(dimensionValues = {"2", "logs", "bulk", "p"}, sum = 0.0, avg = 0.0, min = 0.0, max = 11.0) } ), } ) public static class MetricsAfterEventX { } then from your test method, you can do something like this: @test @AExpect( what = AExpect.Type.REST_API, on = HostTag.DATA_0, validator = UpdatedMetricsPocValidator.class, forRca = RcaItPocDedicated.SimpleAnalysisGraphForDedicated.ClusterRca.class) public void testMetricsUpdated() throws Exception { // Initial logic, uses the Class default metricsDB choice. // ... api.updateMetrics(MetricsAfterEventX.class); // Other test logic follows. }
ktkrg
approved these changes
Dec 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
============================================
- Coverage 73.72% 73.70% -0.02%
+ Complexity 2983 2980 -3
============================================
Files 362 362
Lines 16895 16896 +1
Branches 1372 1372
============================================
- Hits 12455 12453 -2
+ Misses 3997 3995 -2
- Partials 443 448 +5 Continue to review full report at Codecov.
|
rguo-aws
approved these changes
Dec 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: #524
Description of changes:
Today the gauntlet only let's you provide the metricsDB table at the top of a test class
or at the top of a test method. But sometimes during the test test execution, one might want
to change the instance of metricsDB. This is made possible by this patch. In order to do that,
You create a new inner class (doesn't have to be inner) with an appropriate name. Add, the metrics
details as you would if you were to do it as part of the main test class itself.
then from your test method, you can do something like this:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.