This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adding Operational Metrics for Cache RCAs #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushbr
requested review from
yojs,
vigyasharma and
sidheart
and removed request for
vigyasharma
sidheart
approved these changes
Oct 19, 2020
| @@ -121,8 +121,6 @@ public Decision operate() { | |||
| } | |||
|
|
|||
| private void configureModifyCacheActionPriority() { | |||
| // Assigning shard request cache higher priority over field data cache | |||
There was a problem hiding this comment.
nit: It would be nice to have an updated comment on line 124. What does this priority mean?
yojs
approved these changes
Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: #480
Description of changes: This PR adds operational metrics of interest for Cache RCAs and BaseClusterRCA.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.