mount nginx.conf as a volume to the frontend container #244
+115
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ishaan Mittal <[email protected]>
Signed-off-by: Ishaan Mittal <[email protected]>
mittal-ishaan
force-pushed
the
add_frontend_config_to_helm_chart
branch
from
0e24ebf to
6f7d4aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mount
nginx.confas a volume to the frontend container. This way we would me moving out of mounting the nginx.conf to the container when pulling the image in the container as that has permission issues in openshift clusters.Discussion: opencost/opencost-ui#49 (comment)
We need to bump the
opencost-uiimage to have this opencost/opencost-ui#49 changeTesting: I was able to install opencost with these changes