Skip to content

Commit

Permalink
wc - Address PR comments, #TASK-5866, #TASK-5809
Browse files Browse the repository at this point in the history
Signed-off-by: gpveronica <[email protected]>
  • Loading branch information
gpveronica committed Aug 30, 2024
1 parent 0866b76 commit f18e5a4
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 11 deletions.
1 change: 0 additions & 1 deletion src/webcomponents/organization/admin/group-admin-grid.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export default class GroupAdminGrid extends LitElement {
if (this.groups?.length > 0) {
this.renderLocalTable();
}
// this.requestUpdate();
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ export default class GroupAdminPermissionsUpdate extends LitElement {
}

#initPermissions() {
debugger
// 1. Group contains params: (a) id: e.g. "@admins", (b) userIds: e.g. ["test"]
// this.group = this._study.groups.find(group => group.id === this.groupId);
// 2. In the update form, we need to manage as well the permissions of this group.
Expand Down Expand Up @@ -157,7 +156,6 @@ export default class GroupAdminPermissionsUpdate extends LitElement {
}

update(changedProperties) {
debugger
if ((changedProperties.has("groupId") || (changedProperties.has("studyId")) && this.active)) {
this.groupIdObserver();
}
Expand All @@ -171,7 +169,6 @@ export default class GroupAdminPermissionsUpdate extends LitElement {
}

groupIdObserver() {
debugger
if (this.groupId && this.studyId && this.opencgaSession) {
const params = {
member: this.groupId,
Expand Down
Empty file.
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import {LitElement, html, nothing} from "lit";
import UtilsNew from "../../../core/utils-new.js";
import OpencgaCatalogUtils from "../../../core/clients/opencga/opencga-catalog-utils.js";
import ModalUtils from "../../commons/modal/modal-utils.js";
import "./organization-admin-add.js";
import "./organization-admin-owner-update.js";
import "./organization-admin-update.js";

export default class OrganizationAdminDetail extends LitElement {
Expand Down
Empty file.
1 change: 0 additions & 1 deletion src/webcomponents/organization/admin/user-admin-create.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ export default class UserAdminCreate extends LitElement {
#initOriginalObjects() {
this._user = {};
this._config = this.getDefaultConfig();
this.requestUpdate();
}

#setLoading(value) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export default class UserAdminPasswordReset extends LitElement {
return html`<loading-spinner></loading-spinner>`;
}

NotificationUtils.dispatch(this, NotificationUtils.NOTIFY_CONFIRMATION, {
return NotificationUtils.dispatch(this, NotificationUtils.NOTIFY_CONFIRMATION, {
title: `Reset Password: User <b>${this._user.id}</b> in organization ${this.opencgaSession.organization.id}`,
message: `
Are you sure you want to reset ${this._user.id}'s password?
Expand All @@ -123,7 +123,9 @@ export default class UserAdminPasswordReset extends LitElement {
});
}

getDefaultConfig() {}
getDefaultConfig() {
return {};
}

}

Expand Down
2 changes: 0 additions & 2 deletions src/webcomponents/project/project-update.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ export default class ProjectUpdate extends LitElement {
}

#init() {
debugger
this.project = {};
this.updateParams = {};
this.isLoading = false;
Expand All @@ -77,7 +76,6 @@ export default class ProjectUpdate extends LitElement {
}

update(changedProperties) {
debugger
if (changedProperties.has("projectId")) {
this.projectIdObserver();
}
Expand Down

0 comments on commit f18e5a4

Please sign in to comment.