-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce duplicate code for modal content #1059
base: main
Are you sure you want to change the base?
Conversation
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/1059/2025-01-17_12-48-02/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you separate the whitespace changes into a separate commit?
I can try. |
Although the white space changes are directly related to the introduction of the new component, so it seems reasonable to me to have them in the same commit. Can you explain to me how separating them into their own commit helps with |
If the white space changes are directly related to the introduction of the new component then leave them as-is.
This pull request has conflicts ☹ |
This code structure appears in like 50 files, so I'm putting it in a component so I don't have to see it again.
28b518a
to
47d0018
Compare
This pull request has conflicts ☹ |
This code structure appears in like 50 files, so I'm putting it in a component so I don't have to see it again.
While there are many changed lines, 99% of them are indentation changes, so this is hopefully fairly easy to review.
How to test this
Can be tested as usual.