Skip to content

Commit

Permalink
Build of develop from Tue May 14 16:30:09 UTC 2024
Browse files Browse the repository at this point in the history
  • Loading branch information
opencastproject committed May 14, 2024
1 parent 39acaca commit cc59aa1
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 9 deletions.
2 changes: 1 addition & 1 deletion develop/admin/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -766,5 +766,5 @@ <h2 id="release-documentation">Release Documentation</h2>
</html>
<!--
MkDocs version : 1.6.0
Build Date UTC : 2024-05-14 16:05:46.443736+00:00
Build Date UTC : 2024-05-14 16:29:51.168384+00:00
-->
63 changes: 56 additions & 7 deletions develop/commit
Original file line number Diff line number Diff line change
@@ -1,11 +1,60 @@
commit 7d48f14ef7d8f05c8a3bcebed199cfe891228130
commit c1b356871896e780447bfcc035b9893e3f6cb996
Author: Lars Kiesow <[email protected]>
Date: Tue May 14 18:05:08 2024 +0200
Date: Tue May 14 18:29:16 2024 +0200

ESLint nitpicks in the `lti` module (#5830)
Update ESLint (#5831)

Looking at updating ESLint across the board, I found a few small things
in the `lti` package.
ESLint >= 9 brings a few breaking changes, making the dependabot PRs
that try to update it fail; cf. #5824, #5819, #5813, #5812.

* Formatting was werid.
* There was unused ESLint configuration in `package.json`.
The main thing was a change in the default configuration format. There
is a compatibility flag, but I don't think we want to use it, since the
old way is also deprecated now. See also
https://eslint.org/docs/latest/use/migrate-to-9.0.0#-new-default-config-format-eslintconfigjs.

Without that, updating basically entailed the following:

* The shared config in `docs/checkstyle` was converted to the new
format,making it a full `npm`-package in the process.
* This is required because of the way the new format handles plugins and
other dependencies.
* Note that this also makes the `resolve-plugins-relative-to` option
obsolete, which is good since it is no longer supported. This patch
removes it everywhere we used it.
* I also added a dependabot rule to keep that package's few dependencies
up to date.
* The `--config` option can't load such shared configs, though, so all
the packages that use this combination got a new config of their own,
basically deferring to that package.
* Modules which already had their own config file had it updated as
well.
* `.eslintignore` is no longer supported and thus got moved to the new
config file(s).
* I also removed some unnecessary `eslint-disable` comments.

The `eslint-plugin-header` is no longer compatible with ESLint 9. I
replaced it with `eslint-plugin-headers`, but that required kind of an
ugly hack. See also
https://github.com/robmisasi/eslint-plugin-headers/issues/4.

Note that this udpate might slightly change the linting rules; I did not
check every last change to default rules and options! The one thing I
hade to change was to add a setting to the `no-unused-vars`-rule,
because the corresponding default changed, and we depend on the old
default. See also
https://eslint.org/docs/latest/use/migrate-to-9.0.0#-no-unused-vars-now-defaults-caughterrors-to-all.

Note also that the `lti`-module also uses ESLint, but as part of it
being a `create-react-app`, so we don't control the ESLint version in
there. I didn't touch that module. (Well, in this PR; see #5830.) We
might want to change that in the future, though, since CRA is deprecated
in itself.

Another thing we might want to change in the future is the
`engage-paella-player-7`-module using the deprecated
`@babel/eslint-parser`.

We also use a few deprecated ESLint rules, but for now I wanted to
chagne the configs as little as possible, since the necessary changes
are already quite sweeping. I might make a follow-up PR in the coming
days.
2 changes: 1 addition & 1 deletion develop/developer/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -424,5 +424,5 @@ <h1 id="opencast-development-guides">Opencast Development Guides</h1>
</html>
<!--
MkDocs version : 1.6.0
Build Date UTC : 2024-05-14 16:05:47.944997+00:00
Build Date UTC : 2024-05-14 16:29:52.668589+00:00
-->

0 comments on commit cc59aa1

Please sign in to comment.