-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build of develop from Sat Feb 3 17:11:15 UTC 2024
- Loading branch information
1 parent
28031b3
commit 4f912ce
Showing
7 changed files
with
9 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,7 @@ | ||
commit d9bb7c0a2695d2eccb30ff88196d4456170b8830 | ||
Author: Julian Kniephoff <[email protected]> | ||
Date: Wed Jan 31 15:05:08 2024 +0100 | ||
commit 85cc6ab12cdbdb4761645ff8b11adeeb608e685d | ||
Author: Greg Logan <[email protected]> | ||
Date: Sat Feb 3 11:10:37 2024 -0600 | ||
|
||
Hint at how to properly close issues with pull requests (#5257) | ||
Update governance.md | ||
|
||
Mentioning issues in your PR with some magic keywords can automatically | ||
close these issues when the PR is merged. We even hint at this in our | ||
PR-template already. | ||
|
||
However, GitHubs implementation of this does not work super well with | ||
our release/branching model. Specifically, it only works if the PR is | ||
merged into the default branch, which is `develop` in our case. | ||
|
||
It **can** be made to work in our situation if the magic phrases are | ||
mentioned in commit messages alternatively or in addition to the PR | ||
description, because we regularly forward merge the release branches. | ||
|
||
This patch adds a corresponding note about this to the documentation, | ||
and links it in the PR template. | ||
Fixing Lars' employer |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file not shown.