-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build of r/14.x from Mon Oct 30 16:36:27 UTC 2023
- Loading branch information
1 parent
baed6c4
commit 3e4e187
Showing
9 changed files
with
35 additions
and
79 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,5 @@ | ||
commit f9de2789a0039bb915896325eeb16dd68f899da0 | ||
Author: Katrin Ihler <ihler@elan-ev.de> | ||
Date: Fri Oct 27 16:24:46 2023 +0200 | ||
commit 910127b85f9b7af978f4367c525f1cdf2dc124d2 | ||
Author: Lars Kiesow <lkiesow@uos.de> | ||
Date: Mon Oct 30 17:35:25 2023 +0100 | ||
|
||
Fix/improve parts of the Tobira harvest API (subtitles & duration) (#5345) | ||
|
||
Fixes https://github.com/elan-ev/tobira/issues/960 | ||
Fixes https://github.com/elan-ev/tobira/issues/884 | ||
|
||
Look at the commits for more information. | ||
|
||
Note: I was not able to test with events that actually contain | ||
subtitles! Since @KatrinIhler asked for this (for Bern), it would be | ||
very very cool if you could test this. In particular, whether it fixes | ||
the issue you had. | ||
|
||
And if @Arnei has time to take a look at this, I'd be interested in | ||
whether you see any problems with my "find subtitles" logic (second | ||
commit). | ||
|
||
### Your pull request should… | ||
|
||
* [ ] have a concise title | ||
* [ ] [close an accompanying | ||
issue](https://help.github.com/en/articles/closing-issues-using-keywords) | ||
if one exists | ||
* [ ] [be against the correct | ||
branch](https://docs.opencast.org/develop/developer/development-process#acceptance-criteria-for-patches-in-different-versions) | ||
* [ ] include migration scripts and documentation, if appropriate | ||
* [ ] pass automated tests | ||
* [ ] have a clean commit history | ||
* [ ] [have proper commit messages (title and body) for all | ||
commits](https://medium.com/@steveamaza/e028865e5791) | ||
Merge r/13.x into r/14.x |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.