Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CADC-13816] Implement linting and style checks #724

Merged
merged 13 commits into from
Nov 8, 2024

Conversation

shinybrar
Copy link
Collaborator

@shinybrar shinybrar commented Nov 6, 2024

  • Changed style format from cadc-quality to palantir-java-format
  • Changed formatting / lint engine from checkStyle to spotless
  • Added checking for yaml|java|gradle file formats.
  • Fixed excessive token permission issues for codeQL action
  • Changed CodeQL / OpenSSF Scorecard actions to run at midnight each night on schedule.

@shinybrar shinybrar requested a review from at88mph November 6, 2024 23:25
skaha/build.gradle Outdated Show resolved Hide resolved
also fixed build.gradle issues from pr commits
.github/workflows/ci.linting.yml Outdated Show resolved Hide resolved
.github/workflows/ci.testing.yml Outdated Show resolved Hide resolved
at88mph
at88mph previously approved these changes Nov 8, 2024
at88mph
at88mph previously approved these changes Nov 8, 2024
@shinybrar
Copy link
Collaborator Author

Fixes CADC-13811, CADC-13812 and CADC-13816

Copy link

codecov bot commented Nov 8, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

skaha/opencadc.gradle Show resolved Hide resolved
@at88mph at88mph merged commit f94016c into opencadc:main Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants