add voluba v1 linear transform content type #351
Conversation
There was a problem hiding this comment.
@xgui3783 thank you for preparing this PR 🙂 There is one issue that @apdavison should confirm/comment on and one smaller issue for the specification.
| ".json" | ||
| ], | ||
| "name": "application/vnd.voluba.v1.linearTransform+json", | ||
| "relatedMediaType": "https://www.iana.org/assignments/media-types/application/json", |
There was a problem hiding this comment.
this should only be filled if it is an exact match, correct @apdavison ? (or did we now do it also for just "relations"?)
| "synonym": [ | ||
| "Voluba v1 Linear Transformation" | ||
| ], | ||
| "specification": "https://raw.githubusercontent.com/FZJ-INM1-BDA/voluba/fa8e58dbe91a577dd0e6f6a8bf82c06b7e3e72e3/.openminds/voluba.v1.linearTransform.json" |
There was a problem hiding this comment.
this is not the specification 😅 that's just our content type registration. Leave it empty if you do not yet have a documentation on how this JSON looks like (required key-value pairs, expected values, etc.).
If you want to deliver at least a bit of documentation here use the "description" property to write a small (free text) paragraph directly in the content type instance.
|
ping @lzehl, I have fixed the PR according to your suggestions. |
|
@xgui3783 I've updated the indentation to 2 spaces per tab (recent guideline for openMINDS) and updated the synonym a bit. If you are happy with it I can merge it. |
|
@lzehl I am happy! Thanks for your help. |
addresses #350
edit: should also address FZJ-INM1-BDA/voluba#132
cc @fsdavid @JThoennissen If you guys could raise any issue, if you can find any?
ping @lzehl Can you please review?