Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs: Remove Events operations in favor of making whole Logger user-facing #4352

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 8, 2025

Fixes #4234
Fixes #4275
Fixes #4199
Related to #4357

This PR fixes more issues while making the design simpler than:

It does not break anything which was agreed on in https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/0265-event-vision.md.

I think we have gathered enough use cases to make emitting log records user-facing:

Other related OTEP PR:

Here is an OTel Go prototype pre-approved by @open-telemetry/go-maintainers :

I want to add that the other prototype following the current specification was not found acceptable for OTel Go SIG:

@pellared pellared changed the title logs: Remove Events operations in favor of making Logs API user-facing logs: Remove Events operations in favor of making whole Logger user-facing Jan 8, 2025
@pellared pellared self-assigned this Jan 8, 2025
@pellared pellared marked this pull request as ready for review January 9, 2025 19:18
@pellared pellared requested review from a team as code owners January 9, 2025 19:18
@pellared pellared added the spec:logs Related to the specification/logs directory label Jan 9, 2025
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory
Projects
Status: In Progress
Status: In progress
4 participants