-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VertexAI emit user, system, and assistant events #3203
base: main
Are you sure you want to change the base?
Conversation
208af92
to
5033da7
Compare
aedc6f4
to
1760c68
Compare
# message_to_event(message, capture_content) | ||
# ) | ||
) as span: | ||
if span.is_recording(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure log emitting should be governed by span recording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are currently making an implicit assumption that events are recorded as part of a span, but the specification does not explicitly require this—though all the examples at the end show events within spans. It might be worth updating the specification to clarify this expectation either way.
Description
Part of #3041, follow up to #3192
Adds Gen AI events for model input to the VertexAI instrumentation. These are system event, user event, and assistant event.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added test cases for the various log events with
OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT
varied true and false.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.