Skip to content

Commit

Permalink
Fold the content of pprofextended.proto into profiles.proto, removing…
Browse files Browse the repository at this point in the history
… ProfileContainer. (#590)

This change removes the now unnecessary split of the profiling format between two files, combining them into one as with other protocols. In the process, the likewise unnecessary ProfileContainer message type is removed and its fields merged into Profile, saving one level of indirection.

Note this as discussed on slack otel-profiles, this is effectively a minimal subset of the now defunct #587, remaining parts of which will be resubmitted in subsequent PRs.  This PR effectively blocks any concurrent changes to pprofextended.proto e.g. #588 as git won't track such changes across the file 'merge'.
  • Loading branch information
jhalliday authored Oct 15, 2024
1 parent a76fe9d commit 7312bdf
Show file tree
Hide file tree
Showing 2 changed files with 349 additions and 390 deletions.
358 changes: 0 additions & 358 deletions opentelemetry/proto/profiles/v1development/pprofextended.proto

This file was deleted.

Loading

0 comments on commit 7312bdf

Please sign in to comment.