update nodejs autoinstrumetation, fixes #2626

[ElfoLiNk]

Description:

Update nodejs autoinstrumentation like register.ts from auto-instrumentations-node metapackage

Link to tracking Issue(s):

• Resolves: Node.js resource detectors can't be disabled with OTEL_NODE_RESOURCE_DETECTORS #2626

Testing:

Not tested yet

Documentation:

[swiatekm]

@open-telemetry/javascript-approvers could you have a look? 🙏

[ElfoLiNk]

Thank you @pavolloffay i fixed the build since getResourceDetectorsFromEnv is exported as getResourceDetectors

[pichlermarc]

Actually, I think since metrics auto-configuration is now implemented, you may not even need the autoconfigure.ts file anymore. It just duplicates what's happening in @opentelemetry/auto-instrumentations-node/register now (the only difference being that the implementation from the upstream package does not throw when a non-existing exporter is selected)

[ElfoLiNk]

Hi @pichlermarc, are you suggesting to remove autoinstrumentation.ts here and update the code in nodejs.go to something like:

nodeRequireArgument = " --require /otel-auto-instrumentation-nodejs/node_modules/@opentelemetry/auto-instrumentations-node/build/src/register.js"

Would this approach work when referenced like this? I haven’t tested it yet.

Thank you

PS @swiatekm, what’s your opinion on this?

[iblancasa]

Hi @pichlermarc, are you suggesting to remove autoinstrumentation.ts here and update the code in nodejs.go to something like:

nodeRequireArgument = " --require /otel-auto-instrumentation-nodejs/node_modules/@opentelemetry/auto-instrumentations-node/build/src/register.js"

Would this approach work when referenced like this? I haven’t tested it yet.

Thank you

PS @swiatekm, what’s your opinion on this?
It makes sense to me