Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix span setStatus #6990

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Fix span setStatus #6990

merged 2 commits into from
Jan 7, 2025

Conversation

jack-berg
Copy link
Member

Resolves #6797.

Supersedes #6808.

@jack-berg jack-berg requested a review from a team as a code owner January 6, 2025 20:13
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.02%. Comparing base (ccccd1b) to head (5cddee5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../main/java/io/opentelemetry/sdk/trace/SdkSpan.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6990      +/-   ##
============================================
+ Coverage     89.97%   90.02%   +0.05%     
- Complexity     6591     6597       +6     
============================================
  Files           729      729              
  Lines         19852    19858       +6     
  Branches       1953     1955       +2     
============================================
+ Hits          17861    17877      +16     
+ Misses         1396     1387       -9     
+ Partials        595      594       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 5f90b03 into open-telemetry:main Jan 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Span#setStatus
2 participants