-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update prometheusserverversion to v1.3.5 #6957
Conversation
import io.prometheus.metrics.model.registry.PrometheusRegistry; | ||
import io.prometheus.metrics.shaded.com_google_protobuf_4_28_3.TextFormat; | ||
import io.prometheus.metrics.shaded.com_google_protobuf_4_29_1.TextFormat; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shading protobuf output with class packages which incorporate the protobuf version means that updating prometheus dependencies will (almost) always require a code change.
@zeitlinger what are your thoughts on dropping the _4_29_1
suffix from the package name? I.e.
io.prometheus.metrics.shaded.com_google_protobuf_4_29_1
-> io.prometheus.metrics.shaded.com_google_protobuf
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fstab this is a use case where dropping the suffix would help
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6957 +/- ##
=========================================
Coverage 90.08% 90.09%
Complexity 6600 6600
=========================================
Files 730 730
Lines 19843 19843
Branches 1955 1955
=========================================
+ Hits 17876 17877 +1
Misses 1371 1371
+ Partials 596 595 -1 ☔ View full report in Codecov by Sentry. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
1.3.4
->1.3.5
1.3.4
->1.3.5
Release Notes
prometheus/client_java (io.prometheus:prometheus-metrics-exposition-formats)
v1.3.5
What's Changed
Full Changelog: prometheus/client_java@v1.3.4...v1.3.5
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.