Call NewSpanExporter without checking OTLP_TRACES_EXPORTER environment variable #1572
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
MrAlias
reviewed
Jan 9, 2025
| // a way to just pass the environment value currently. Just use | ||
| // NewSpanExporter which will re-read this value. | ||
|
|
||
| { |
There was a problem hiding this comment.
The sub-scope is not needed here and only adds additional indentation.
Suggested change
| { |
| // Test that autoexport.NewSpanExporter works when OTEL_TRACES_EXPORTER is | ||
| // not set | ||
| t.Run("With OTEL_TRACES_EXPORTER not set", func(t *testing.T) { | ||
| os.Unsetenv("OTEL_TRACES_EXPORTER") |
There was a problem hiding this comment.
We want to test when this is unset but OTEL_EXPORTER_OTLP_PROTOCOL is set.
Suggested change
| os.Unsetenv("OTEL_TRACES_EXPORTER") | |
| os.Unsetenv("OTEL_TRACES_EXPORTER") | |
| t.Setenv("OTEL_EXPORTER_OTLP_PROTOCOL", "grpc") |
| c, err := newInstConfig(context.Background(), []InstrumentationOption{WithEnv()}) | ||
|
|
||
| require.NoError(t, err) | ||
| assert.NotNil(t, c.traceExp) |
There was a problem hiding this comment.
This should validate the instance type to be and exporter from otlptracegrpc. Given the structure of those exporters, calling MarshalLog is likely your best option.
Suggested change
| assert.NotNil(t, c.traceExp) | |
| require.NotNil(t, c.traceExp) | |
| require.IsType(t, &otlptrace.Exporter{}, c.traceExp) | |
| exp := c.traceExp.(*otlptrace.Exporter) | |
| var buf bytes.Buffer | |
| logger := stdr.New(log.New(&buf, "", log.LstdFlags)) | |
| logger.Info("", "exporter", exp) | |
| got, err := io.ReadAll(&buf) | |
| require.NoError(t, err) | |
| // "otlphttphttp" should be "otlptracegrpc". This is a bug upstream. | |
| assert.Contains(t, string(got), "otlphttpgrpc") |
There was a problem hiding this comment.
Will be impacted by open-telemetry/opentelemetry-go#6143. We can follow up with that update later though.
|
Please be sure to include a changelog entry describing the fix being applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
OTEL_TRACES_EXPORTERis not defined, then the trace exporter is always set to HTTP, regardless of the value ofOTEL_EXPORTER_OTLP_PROTOCOL. This is because there is a check to see ifOTEL_TRACES_EXPORTERis set before callingautoexport.NewSpanExporter.This change removes that check and adds a test to ensure that
autoexport.NewSpanExporterstill works withoutOTEL_TRACES_EXPORTERdefined. I have left the fallback code in place here so that ifOTEL_EXPORTER_OTLP_PROTOCOLhas an invalid value (or NewSpanExporter returns nil for any other reason) the http exporter will be selected (which is the current behaviour).