Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Implement spec: MetricFilter #3235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SDK] Implement spec: MetricFilter #3235

wants to merge 1 commit into from

Conversation

IcySteam
Copy link

@IcySteam IcySteam commented Jan 9, 2025

Fixes #2447

Changes

This PR implements the MetricFilter spec in opentelemetry-cpp.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed
    • MetricProducer::MetricProducer
    • MetricCollector::MetricCollector
    • MeterContext::AddMetricReader
    • MeterProvider::AddMetricReader

@IcySteam IcySteam requested a review from a team as a code owner January 9, 2025 11:15
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 9, 2025 •
edited
Loading

CLA Not Signed

@netlify Netlify
Copy link

netlify bot commented Jan 9, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 9e8e4b7
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/677fb8e1e6e92800082357f0

@IcySteam IcySteam force-pushed the otel-metricfilter-fn branch 2 times, most recently from 4d8e499 to 353ad0d Compare January 9, 2025 11:46
@IcySteam IcySteam force-pushed the otel-metricfilter-fn branch from bbd4ca5 to 9e8e4b7 Compare January 9, 2025 11:54
@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:waiting-on-cla Waiting on CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK] Add predicate to MetricReader and MetricProducer
2 participants
@IcySteam @marcalff